[v1.12.0] Fix non-reentrant hooks based checkpointing #79490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohan-varma
requested review from
mrshenli,
pritamdamania87,
zhaojuanmao,
H-Huang,
awgu and
mingzhe09088
as code owners
🔗 Helpful links
✅ No Failures (0 Pending)As of commit ad2e8ff (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: distributed
rohan-varma
added
ciflow/trunk
malfet
requested changes
Jun 14, 2022
There was a problem hiding this comment.
PR targeting release branch does not seem to match one for master.
@rohan-varma can you please explain the differences?
|
Discussing offline with @malfet |
|
Only difference is change in set of tests in |
malfet
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to landed master PR: #78752
Original commit description:
Fixes the non-reentrant hooks based checkpointing to actually save memory. The issue was that
storagewas a list of autograd saved tensors and we weren't clearing this list out as tensors were accessed, so all activations would remain in memory. Now at the end of the layer's backwards pass, activations will be discarded as expected.Adding unittests to ensure:
Also, this means we can enable non-reentrant based checkpointing in
CheckpointWrapper, will also add unittests for that.