Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call PyArray_Check only if NumPy is available (#66433) #66629

Merged
merged 1 commit into from Oct 14, 2021

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Oct 14, 2021

Summary:
Fixes #66353

Pull Request resolved: #66433

Reviewed By: seemethere, janeyx99

Differential Revision: D31548290

Pulled By: malfet

fbshipit-source-id: 3b094bc8195d0392338e0bdc6df2f39587b85bb3

Summary:
Fixes pytorch#66353

Fixes #{issue number}

Pull Request resolved: pytorch#66433

Reviewed By: seemethere, janeyx99

Differential Revision: D31548290

Pulled By: malfet

fbshipit-source-id: 3b094bc8195d0392338e0bdc6df2f39587b85bb3
@pytorch-probot
Copy link

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/malfet/pytorch/blob/e65a0842c3b762887ebba2b29eefd116d5d1dfeb/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-bionic-py3.6-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/xla ✅ triggered
linux-bionic-py3.8-gcc9-coverage ciflow/all, ciflow/coverage, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/win ✅ triggered
Skipped Workflows
libtorch-linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
parallelnative-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
puretorch-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
win-vs2019-cuda10.2-py3 ciflow/all, ciflow/cuda, ciflow/win 🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands:
# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 14, 2021

🔗 Helpful links

💊 CI failures summary and remediations

As of commit e65a084 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build linux-xenial-py3.6-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2021-10-14T17:01:02.6344852Z RuntimeError:
2021-10-14T17:01:01.9971393Z Author: PyTorch Team
2021-10-14T17:01:01.9972018Z Author-email: packages@pytorch.org
2021-10-14T17:01:01.9972578Z License: BSD-3
2021-10-14T17:01:01.9973196Z Location: /opt/conda/lib/python3.6/site-packages
2021-10-14T17:01:01.9973919Z Requires: dataclasses, typing-extensions
2021-10-14T17:01:01.9974478Z Required-by: 
2021-10-14T17:01:02.0173543Z + python check_backward_compatibility.py --existing-schemas nightly_schemas.txt
2021-10-14T17:01:02.6342956Z Traceback (most recent call last):
2021-10-14T17:01:02.6343899Z   File "check_backward_compatibility.py", line 155, in <module>
2021-10-14T17:01:02.6344422Z     s = parse_schema(line.strip())
2021-10-14T17:01:02.6344852Z RuntimeError: 
2021-10-14T17:01:02.6345383Z Unknown custom class type cuda.Stream. Please ensure it is registered.:
2021-10-14T17:01:02.6346933Z cuda::default_stream.device(Device? device) -> (__torch__.torch.classes.cuda.Stream)
2021-10-14T17:01:02.6347689Z                                                                              ~~~~~~ <--- HERE
2021-10-14T17:01:02.6347935Z 
2021-10-14T17:01:02.7257947Z + cleanup
2021-10-14T17:01:02.7258524Z + retcode=1
2021-10-14T17:01:02.7258938Z + set +x
2021-10-14T17:01:02.7259295Z =================== sccache compilation log ===================
2021-10-14T17:01:02.7460090Z =========== If your build fails, please take a look at the log above for possible reasons ===========
2021-10-14T17:01:02.7479649Z Compile requests                      0

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@malfet malfet merged commit 4a514dd into pytorch:release/1.10 Oct 14, 2021
@malfet malfet deleted the malfet/cp-66433 branch October 14, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants