New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call PyArray_Check
only if NumPy is available
#66433
Call PyArray_Check
only if NumPy is available
#66433
Conversation
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow For more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit d7145f4 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm: linux-xenial-cuda11.3-py3.6-gcc7 / test (default, 2, 2, linux.8xlarge.nvidia.gpu) (1/1)Step: "Install nvidia driver, nvidia-docker runtime, set GPU_FLAG" (full log | diagnosis details | 🔁 rerun) ❄️
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
I was looking into the same lines of code, but couldn't narrow it down to a missing numpy check, since a source build wasn't failing there. Do you know, why the binaries were hitting the issue, while a source build (without numpy) was working fine? |
I guess the expectation with binary builds is that they always build with |
Summary: Fixes pytorch#66353 Fixes #{issue number} Pull Request resolved: pytorch#66433 Reviewed By: seemethere, janeyx99 Differential Revision: D31548290 Pulled By: malfet fbshipit-source-id: 3b094bc8195d0392338e0bdc6df2f39587b85bb3
Fixes #66353