Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cosine similarity dim checks #66214

Merged
merged 2 commits into from Oct 8, 2021
Merged

Fix cosine similarity dim checks #66214

merged 2 commits into from Oct 8, 2021

Conversation

ngimel
Copy link
Collaborator

@ngimel ngimel commented Oct 6, 2021

1.10 version of #66191

@pytorch-probot
Copy link

pytorch-probot bot commented Oct 6, 2021

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/164f152b849baedcce7a7c260a0fcea9f4228391/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-bionic-py3.6-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/xla ✅ triggered
linux-bionic-py3.8-gcc9-coverage ciflow/all, ciflow/coverage, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/win ✅ triggered
Skipped Workflows
libtorch-linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
parallelnative-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
puretorch-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
win-vs2019-cuda10.2-py3 ciflow/all, ciflow/cuda, ciflow/win 🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands:
# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 6, 2021

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 164f152 (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build linux-xenial-cuda11.3-py3.6-gcc7 / test (distributed, 1, 1, linux.8xlarge.nvidia.gpu) (1/2)

Step: "Download PyTorch Build Artifacts" (full log | diagnosis details | 🔁 rerun)

2021-10-06T19:00:07.5597593Z CONTINUE_THROUGH_ERROR: false
2021-10-06T19:00:07.5588496Z   CUSTOM_TEST_ARTIFACT_BUILD_DIR: build/custom_test_artifacts
2021-10-06T19:00:07.5589374Z   ALPINE_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/tool/alpine
2021-10-06T19:00:07.5590069Z   PR_LABELS: []
2021-10-06T19:00:07.5591475Z   GITHUB_TOKEN: ***
2021-10-06T19:00:07.5592988Z   DOCKER_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-xenial-cuda11.3-cudnn8-py3-gcc7:74e757e8b0cf750d2f91db6aa4c29640abce32ea
2021-10-06T19:00:07.5594737Z   JOB_BASE_NAME: linux-xenial-cuda11.3-py3.6-gcc7-test
2021-10-06T19:00:07.5595517Z   TEST_CONFIG: distributed
2021-10-06T19:00:07.5595964Z   SHARD_NUMBER: 1
2021-10-06T19:00:07.5596560Z   NUM_TEST_SHARDS: 1
2021-10-06T19:00:07.5597062Z   PYTORCH_IGNORE_DISABLED_ISSUES: 
2021-10-06T19:00:07.5597593Z   CONTINUE_THROUGH_ERROR: false
2021-10-06T19:00:07.5598084Z   GPU_FLAG: --gpus all
2021-10-06T19:00:07.5598487Z   SHM_SIZE: 2g
2021-10-06T19:00:07.5598893Z ##[endgroup]
2021-10-06T19:00:07.6367759Z "docker stop" requires at least 1 argument.
2021-10-06T19:00:07.6368997Z See 'docker stop --help'.
2021-10-06T19:00:07.6369350Z 
2021-10-06T19:00:07.6369905Z Usage:  docker stop [OPTIONS] CONTAINER [CONTAINER...]
2021-10-06T19:00:07.6370341Z 
2021-10-06T19:00:07.6370820Z Stop one or more running containers
2021-10-06T19:00:11.7362275Z Deleted Images:

See GitHub Actions build linux-xenial-py3.6-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2021-10-06T18:49:45.1861104Z RuntimeError:
2021-10-06T18:49:44.5762976Z Author: PyTorch Team
2021-10-06T18:49:44.5763481Z Author-email: packages@pytorch.org
2021-10-06T18:49:44.5763939Z License: BSD-3
2021-10-06T18:49:44.5764476Z Location: /opt/conda/lib/python3.6/site-packages
2021-10-06T18:49:44.5765119Z Requires: dataclasses, typing-extensions
2021-10-06T18:49:44.5765617Z Required-by: 
2021-10-06T18:49:44.5969719Z + python check_backward_compatibility.py --existing-schemas nightly_schemas.txt
2021-10-06T18:49:45.1859437Z Traceback (most recent call last):
2021-10-06T18:49:45.1860145Z   File "check_backward_compatibility.py", line 155, in <module>
2021-10-06T18:49:45.1860672Z     s = parse_schema(line.strip())
2021-10-06T18:49:45.1861104Z RuntimeError: 
2021-10-06T18:49:45.1861712Z Unknown custom class type cuda.Stream. Please ensure it is registered.:
2021-10-06T18:49:45.1863178Z cuda::default_stream.device(Device? device) -> (__torch__.torch.classes.cuda.Stream)
2021-10-06T18:49:45.1863991Z                                                                              ~~~~~~ <--- HERE
2021-10-06T18:49:45.1864231Z 
2021-10-06T18:49:45.2755363Z + cleanup
2021-10-06T18:49:45.2755738Z + retcode=1
2021-10-06T18:49:45.2756046Z + set +x
2021-10-06T18:49:45.2756398Z =================== sccache compilation log ===================
2021-10-06T18:49:45.2947765Z =========== If your build fails, please take a look at the log above for possible reasons ===========
2021-10-06T18:49:45.2999601Z Compile requests                      0

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #66214 (164f152) into release/1.10 (5f1a434) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           release/1.10   #66214      +/-   ##
================================================
- Coverage         66.32%   66.32%   -0.01%     
================================================
  Files               738      738              
  Lines             94268    94270       +2     
================================================
  Hits              62524    62524              
- Misses            31744    31746       +2     

@malfet malfet merged commit 9509e8a into release/1.10 Oct 8, 2021
@ngimel ngimel deleted the ngimel/cos_sim_1.10 branch December 26, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants