Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further explanation for batch_isend_irecv #125099

Open
botbw opened this issue Apr 27, 2024 · 1 comment
Open

Further explanation for batch_isend_irecv #125099

botbw opened this issue Apr 27, 2024 · 1 comment
Assignees
Labels
oncall: distributed Add this issue/PR to distributed oncall triage queue triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@botbw
Copy link

botbw commented Apr 27, 2024

馃摎 The doc issue

here the doc string says the function will return dist.Work by calling corresponding ops, however the returned reqs might not be "corresponding" (e.g. batch_isend_irect([op1, op2]) might return only one [coalescing_req]), which is quite confusing. (Or can we have a 1-to-1 mapping for p2p_op_list and returned reqs?

Args:
    p2p_op_list: A list of point-to-point operations(type of each operator is
        ``torch.distributed.P2POp``). The order of the isend/irecv in the list
        matters and it needs to match with corresponding isend/irecv on the
        remote end.

Returns:
    A list of distributed request objects returned by calling the corresponding
    op in the op_list.

Suggest a potential alternative/fix

No response

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k

@botbw botbw changed the title Further explanation for batch_isend_irect Further explanation for batch_isend_irecv Apr 27, 2024
@cpuhrsch cpuhrsch added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Apr 30, 2024
@kwen2501 kwen2501 self-assigned this May 1, 2024
@kwen2501
Copy link
Contributor

kwen2501 commented May 1, 2024

Thanks, we will improve the document.

@LucasLLC LucasLLC added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oncall: distributed Add this issue/PR to distributed oncall triage queue triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

4 participants