Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 on torch.inference_mode doc page #125059

Open
alat-rights opened this issue Apr 26, 2024 · 3 comments
Open

404 on torch.inference_mode doc page #125059

alat-rights opened this issue Apr 26, 2024 · 3 comments
Labels
module: autograd Related to torch.autograd, and the autograd engine in general module: docs Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@alat-rights
Copy link
Contributor

alat-rights commented Apr 26, 2024

馃摎 The doc issue

The page for torch.autograd.grad_mode.inference_mode is still up

However, the page for torch.inference_mode is down, leaving a dead link on Google and my bookmarks :'( .

image

Suggest a potential alternative/fix

Restore the page for torch.inference_mode

cc @svekars @brycebortree @ezyang @albanD @gqchen @pearu @nikitaved @soulitzer @lezcano @Varal7

@alat-rights alat-rights changed the title 404 on torch.inference_mode doc https://pytorch.org/docs/stable/generated/torch.inference_mode.html 404 on torch.inference_mode doc page Apr 26, 2024
@mikaylagawarecki mikaylagawarecki added module: autograd Related to torch.autograd, and the autograd engine in general triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Apr 26, 2024
@malfet malfet added the module: docs Related to our documentation, both in docs/ and docblocks label Apr 27, 2024
@albanD
Copy link
Collaborator

albanD commented Apr 30, 2024

This is expected, since this is the same function aliased on different namespaces, we de-duplicated all of them.
If you look for inference_mode, everything should point to the still exiting page and nothing should point you to a 404!

Or is there a way to reach that 404 through some link in the doc page?

@alat-rights
Copy link
Contributor Author

I see!

No, I didn't get there from an internal link.

I got to the page via the top Google result for "pytorch inference mode".

I think it's a little unfortunate that the top result on both Google and DDG for inference_mode is currently a dead link, but obviously if it's costly to maintain the page then that makes sense :)

@albanD
Copy link
Collaborator

albanD commented May 1, 2024

Ho I can see!
cc @svekars did we properly run the script to update indexing on google after the 2.3 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: autograd Related to torch.autograd, and the autograd engine in general module: docs Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

4 participants