Enable UFMT on test/test_functionalization.py #123926

huniu20 · 2024-04-12T09:37:51Z

Part of #123062
cc @ezyang

pytorch-bot · 2024-04-12T09:37:55Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123926

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit d02183a with merge base 9dfeec9 ():

NEW FAILURES - The following jobs have failed:

pull / linux-focal-py3.12-clang10 / test (dynamo, 1, 3, linux.2xlarge) (gh)
RuntimeError: test_torch 1/1 failed
pull / linux-focal-py3.12-clang10 / test (dynamo, 2, 3, linux.2xlarge) (gh)
RuntimeError: test_fx 1/1 failed
pull / linux-focal-py3.12-clang10 / test (dynamo, 3, 3, linux.2xlarge) (gh)
Process completed with exit code 1.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang · 2024-04-12T15:37:15Z

clean

diff --git b/test/test_functionalization.py a/test/test_functionalization.py
index 3c1f3c823f2..e79ab0910ef 100644
--- b/test/test_functionalization.py
+++ a/test/test_functionalization.py
@@ -81,6 +81,7 @@ def _functionalize(
     TEST_WITH_TORCHDYNAMO, "https://github.com/pytorch/pytorch/issues/81457"
 )
 class TestFunctionalization(TestCase):
+
     crossref = False
 
     def get_logs(self, func, *inpts, reapply_views=False, run_reinplace=False):

ezyang · 2024-04-12T15:37:30Z

@pytorchbot merge

pytorchmergebot · 2024-04-12T15:39:17Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-04-12T15:54:51Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / lintrunner-noclang / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

ezyang · 2024-04-13T03:23:10Z

needs some more whackin

ezyang · 2024-04-14T12:57:03Z

clean

ezyang · 2024-04-14T12:57:07Z

@pytorchbot merge

pytorchmergebot · 2024-04-14T12:58:55Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-04-14T13:09:32Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / lintrunner-noclang / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

huniu20 · 2024-04-14T13:55:13Z

@ezyang Hello, Yang, thank you for reviewing this PR. I don't know how to fix this failure of CI, I would be very grateful if you could give me some advice.

ezyang · 2024-04-15T03:23:53Z

you need to move the noflake pragmas so that they are on the quoted string line, black moved them to the wrong line

statelesshz

for reference only :)

statelesshz · 2024-04-18T08:25:09Z

test/test_functionalization.py

@@ -217,7 +268,8 @@ def forward(self, arg0_1):
    view_copy_11 = torch.ops.aten.view_copy.default(view_copy_8, [16, 64, 128, 128]);  view_copy_8 = None
    detach_copy_1 = torch.ops.aten.detach_copy.default(view_copy_11);  view_copy_11 = None
    return detach_copy_1
-    """)  # noqa: B950
+    """,


Suggested change

""",

""", # noqa: B950

test/test_functionalization.py

statelesshz · 2024-04-18T08:28:13Z

test/test_functionalization.py

@@ -455,16 +560,20 @@ def forward(self, arg0_1):
    getitem_5 = _fused_moving_avg_obs_fq_helper_functional[5];  _fused_moving_avg_obs_fq_helper_functional = None
    copy_ = torch.ops.aten.copy_.default(arg0_1, getitem_5);  arg0_1 = getitem_5 = None
    return (getitem, getitem_1)
-    """)  # noqa: B950
+    """,
+        )  # noqa: B950


Move the noflake pragma so that it is on the quoted string line

huniu20 · 2024-04-26T02:19:47Z

@ezyang Hi, sorry about the delay of fix noflake issues and thanks for your review

pytorchmergebot · 2024-04-26T03:12:56Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-04-26T03:13:02Z

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

ezyang · 2024-04-26T15:25:42Z

@pytorchbot merge

pytorchmergebot · 2024-04-26T15:29:47Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-04-26T16:21:29Z

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

huniu20 · 2024-04-28T03:02:38Z

@ezyang Hello, Yang, I don't know what was wrong with the failure of CI. This PR does not involve those three files:

test/test_proxy_tensor.py
test/test_torch.py
test/test_fx.py

BTW, those three tests all passed locally using python -m pytest test/test_xxx.py.

huniu20 · 2024-04-28T03:03:25Z

Thanks a lot for your kind review 💯

ezyang · 2024-04-28T17:00:42Z

@pytorchbot merge -f "I think these are unrelated"

pytorchmergebot · 2024-04-28T17:02:23Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Part of pytorch#123062 Pull Request resolved: pytorch#123926 Approved by: https://github.com/ezyang, https://github.com/statelesshz

1. Enable EFMT on test/test_functionalization.py

8e78044

pytorch-bot bot added the topic: not user facing topic category label Apr 12, 2024

pytorchbot added the open source label Apr 12, 2024

huniu20 changed the title ~~Enable EFMT on test/test_functionalization.py~~ Enable UFMT on test/test_functionalization.py Apr 12, 2024

ezyang approved these changes Apr 12, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 12, 2024

pytorchmergebot added the merging label Apr 12, 2024

pytorchmergebot removed the merging label Apr 12, 2024

ezyang mentioned this pull request Apr 13, 2024

Enable UFMT on all files in PyTorch #123062

Open

huniu20 added 2 commits April 14, 2024 15:56

modify some lint issues

4c08778

fix bug

b3d0850

pytorchmergebot added the merging label Apr 14, 2024

pytorchmergebot removed the merging label Apr 14, 2024

statelesshz approved these changes Apr 18, 2024

View reviewed changes

fix FLAKE issues

d02183a

pytorchmergebot added the merging label Apr 26, 2024

pytorchmergebot removed the merging label Apr 26, 2024

pytorchmergebot added the merging label Apr 26, 2024

pytorchmergebot removed the merging label Apr 26, 2024

pytorchmergebot added the merging label Apr 28, 2024

pytorchmergebot added the Merged label Apr 28, 2024

pytorchmergebot closed this in 518ab48 Apr 28, 2024

pytorchmergebot removed the merging label Apr 28, 2024

andoorve pushed a commit to andoorve/pytorch that referenced this pull request May 1, 2024

Enable UFMT on test/test_functionalization.py (pytorch#123926)

ad1feb8

Part of pytorch#123062 Pull Request resolved: pytorch#123926 Approved by: https://github.com/ezyang, https://github.com/statelesshz

petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024

Enable UFMT on test/test_functionalization.py (pytorch#123926)

7a01b5d

Part of pytorch#123062 Pull Request resolved: pytorch#123926 Approved by: https://github.com/ezyang, https://github.com/statelesshz

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable UFMT on test/test_functionalization.py #123926

Enable UFMT on test/test_functionalization.py #123926

huniu20 commented Apr 12, 2024 •

edited

pytorch-bot bot commented Apr 12, 2024 •

edited

ezyang commented Apr 12, 2024

ezyang commented Apr 12, 2024

pytorchmergebot commented Apr 12, 2024

pytorchmergebot commented Apr 12, 2024

ezyang commented Apr 13, 2024

ezyang commented Apr 14, 2024

ezyang commented Apr 14, 2024

pytorchmergebot commented Apr 14, 2024

pytorchmergebot commented Apr 14, 2024

huniu20 commented Apr 14, 2024

ezyang commented Apr 15, 2024

statelesshz left a comment

statelesshz Apr 18, 2024

statelesshz Apr 18, 2024

huniu20 commented Apr 26, 2024

pytorchmergebot commented Apr 26, 2024

pytorchmergebot commented Apr 26, 2024

ezyang commented Apr 26, 2024

pytorchmergebot commented Apr 26, 2024

pytorchmergebot commented Apr 26, 2024

huniu20 commented Apr 28, 2024

huniu20 commented Apr 28, 2024

ezyang commented Apr 28, 2024

pytorchmergebot commented Apr 28, 2024

Enable UFMT on test/test_functionalization.py #123926

Enable UFMT on test/test_functionalization.py #123926

Conversation

huniu20 commented Apr 12, 2024 • edited

pytorch-bot bot commented Apr 12, 2024 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123926

❌ 3 New Failures

ezyang commented Apr 12, 2024

ezyang commented Apr 12, 2024

pytorchmergebot commented Apr 12, 2024

Merge started

pytorchmergebot commented Apr 12, 2024

Merge failed

ezyang commented Apr 13, 2024

ezyang commented Apr 14, 2024

ezyang commented Apr 14, 2024

pytorchmergebot commented Apr 14, 2024

Merge started

pytorchmergebot commented Apr 14, 2024

Merge failed

huniu20 commented Apr 14, 2024

ezyang commented Apr 15, 2024

statelesshz left a comment

Choose a reason for hiding this comment

statelesshz Apr 18, 2024

Choose a reason for hiding this comment

statelesshz Apr 18, 2024

Choose a reason for hiding this comment

huniu20 commented Apr 26, 2024

pytorchmergebot commented Apr 26, 2024

Merge started

pytorchmergebot commented Apr 26, 2024

Merge failed

ezyang commented Apr 26, 2024

pytorchmergebot commented Apr 26, 2024

Merge started

pytorchmergebot commented Apr 26, 2024

Merge failed

huniu20 commented Apr 28, 2024

huniu20 commented Apr 28, 2024

ezyang commented Apr 28, 2024

pytorchmergebot commented Apr 28, 2024

Merge started

huniu20 commented Apr 12, 2024 •

edited

pytorch-bot bot commented Apr 12, 2024 •

edited