Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytorch cuda in registry nightly images #1432

Open
bhack opened this issue Jun 16, 2023 · 5 comments
Open

Pytorch cuda in registry nightly images #1432

bhack opened this issue Jun 16, 2023 · 5 comments
Assignees

Comments

@bhack
Copy link

bhack commented Jun 16, 2023

Are you testing if the nightly image is usable with cuda?

torch.cuda._is_compiled() is false inside the last nightly image

We should add docker images to validation framework.

Workflow:
https://github.com/pytorch/pytorch/blob/main/.github/workflows/docker-release.yml

Docker containers are located here:
https://github.com/orgs/pytorch/packages/container/package/pytorch

Simple install command:
docker pull ghcr.io/pytorch/pytorch:2.2.1-cuda11.8-cudnn8-devel

Build workflow:
https://github.com/pytorch/pytorch/actions/runs/8200189724/job/22426518545

@bhack bhack changed the title Pytorch cuda in nighlty images in the registry Pytorch cuda in registry nightly images Jun 20, 2023
@atalman
Copy link
Contributor

atalman commented Apr 2, 2024

We should add automation around validation of docker images for both nightly and releases. Release workflow: https://github.com/pytorch/pytorch/actions/runs/8393526521/job/22988732918

Onboard to validation framework:
https://github.com/pytorch/builder/actions/workflows/validate-binaries.yml

@atalman
Copy link
Contributor

atalman commented Apr 3, 2024

cc @juliagmt-google

@juliagmt-google
Copy link
Contributor

Thanks for sharing the task and details. Here are my questions:

  1. torch.cuda._is_compiled() is false inside the last nightly image: where can I see the output?
  2. What exactly is the validation?
  3. I saw docker pull ghcr.io/pytorch/pytorch:2.2.2-cuda11.8-cudnn8-devel in https://github.com/orgs/pytorch/packages/container/package/pytorch where Docker containers are located, but the instruction says installing docker pull ghcr.io/pytorch/pytorch:2.2.1-cuda11.8-cudnn8-devel, which has a different PyTorch version. Which command should I use?
  4. Which files do we need to change to add automation and validation?

@atalman
Copy link
Contributor

atalman commented Apr 4, 2024

@juliagmt-google
Copy link
Contributor

For gpu runners we need to use pytorch/test-infra/.github/workflows/linux_job.yml@main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants