You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the current code, python_nodot will only be defined if the previous if statement is satisfied. Otherwise, it would be empty and would not work for cases where Python version is 3.10 and above.
Example:
DESIRED_PYTHON=cp310-cp310 if [[ -n "$DESIRED_PYTHON" && "$DESIRED_PYTHON" != cp* ]]; then statement not met, so python_nodot is not defined. Then next if statement is not satisfied and hence go in the else statement. Hence, py_majmin=3.1, which gives error here
if [[ ${python_nodot}-ge 310 ]];then
py_majmin="${DESIRED_PYTHON:2:1}.${DESIRED_PYTHON:3:2}"else
py_majmin="${DESIRED_PYTHON:2:1}.${DESIRED_PYTHON:3:1}"fi
One solution I can think of is defining python_nodot before the python_nodot if else loop:
python_nodot="$(echo ${DESIRED_PYTHON%%-*} | tr -cd '[:digit:]')"
In the current code, python_nodot will only be defined if the previous
if
statement is satisfied. Otherwise, it would be empty and would not work for cases where Python version is 3.10 and above.builder/manywheel/build_common.sh
Line 90 in d7ad1b3
Example:
DESIRED_PYTHON=cp310-cp310
if [[ -n "$DESIRED_PYTHON" && "$DESIRED_PYTHON" != cp* ]]; then
statement not met, so python_nodot is not defined. Then next if statement is not satisfied and hence go in the else statement. Hence, py_majmin=3.1, which gives error herebuilder/manywheel/build_common.sh
Line 464 in d7ad1b3
One solution I can think of is defining python_nodot before the python_nodot if else loop:
python_nodot="$(echo ${DESIRED_PYTHON%%-*} | tr -cd '[:digit:]')"
cc @malfet
The text was updated successfully, but these errors were encountered: