New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VS installer exited with code -1 flakily when building Windows binaries #1387
Comments
VS2022 should be part of AMI, sholdn't it? |
It looks like there is a gap here. The installation script used by the AMI https://github.com/pytorch/test-infra/blob/main/aws/ami/windows/scripts/Installers/Install-VS.ps1#L34 looks older and still uses VS2019. Thus it makes sense that VS2022 is installed every time |
Note there is a PR that should update the VS on the AMI pending pytorch/test-infra#1175. I haven't touched it for a while but I can revive it if needed. |
Also note, that thre might be a bug in collecting the VS logs that would be helpfull for reporting the issue: The workflow compresses the logs into
|
To summary my chat with @malfet on the issue:
|
…90855) (#99591) This reverts commit a88c15a. Once we have the AMI ready, we can revert this and use VS2022 again. This is to mitigate flaky Windows build in trunk pytorch/builder#1387. Note that as VS2019 is already available in the current AMI, it won't be installed again per logic in https://github.com/pytorch/builder/blob/main/windows/internal/vs2019_install.ps1#L25-L29. Thus, this helps avoid the flaky installation issue. Pull Request resolved: #99591 Approved by: https://github.com/kit1980, https://github.com/Blackhex, https://github.com/malfet
I'm currently seeing quite a number of flaky failures when building Windows binaries in trunk, for example https://github.com/pytorch/pytorch/actions/runs/4744014597/jobs/8424319388
The error is pointing to this step https://github.com/pytorch/builder/blob/main/windows/internal/vs2022_install.ps1#L42 in which
vs_installer.exe
is installed. The exact error isVS installer exited with code -1, which should be one of [0, 3010]
. I have already tried to disabled Windows Defender there (pytorch/pytorch#99389) but it doesn't seem to help.Another minor bug is when
vslogs.zip
is copied at https://github.com/pytorch/builder/blob/main/windows/internal/vs2022_install.ps1#L54. The correct path should beC:\Users\${env:USERNAME}\AppData\Local\Temp\vslogs.zip
as the user is nowrunneruser
instead ofcircleci
. This hides the above error.cc @atalman @malfet @Blackhex
The text was updated successfully, but these errors were encountered: