Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for multi-device safe mode in C++ #2824

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented May 9, 2024

Description

  • Adds mirror functions and testing in C++ to control the MULTI_DEVICE_SAFE_MODE flag

Fixes #2813

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive self-assigned this May 9, 2024
@gs-olive gs-olive changed the title feat: Add support for multi-device safe mode modification in cpp feat: Add support for multi-device safe mode in C++ May 9, 2024
@github-actions github-actions bot added component: tests Issues re: Tests component: core Issues re: The core compiler component: runtime labels May 9, 2024
@github-actions github-actions bot requested a review from narendasan May 9, 2024 16:02
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants