Fix Tlz error in Python 3.11 (alpha) #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to make a new release with those fixes? |
Will do! |
|
Released. Sorry for the delay--I wanted to figure out building wheels for |
weiji14
added a commit
to weiji14/zen3geo
that referenced
this pull request
Mar 17, 2023
Bumps [toolz](https://github.com/pytoolz/toolz) from 0.11.2 to 0.12.0. - [Release notes](https://github.com/pytoolz/toolz/releases) - [Changelog](https://github.com/pytoolz/toolz/blob/master/release-notes) - [Commits](pytoolz/toolz@0.11.2...0.12.0) Fixes `AttributeError: 'TlzSpec' object has no attribute '_uninitialized_submodules'`, xref pytoolz/toolz#533
weiji14
added a commit
to weiji14/zen3geo
that referenced
this pull request
Mar 17, 2023
Run Continuous Integration tests and workflows on Python 3.11. Need to bump pyproj, numpy, pandas, rasterio, fiona, pyogrio, toolz and shapely (plus a few others) to get versions with Python 3.11 wheels. * ⬆️ Bump pyproj from 3.3.1 to 3.4.1 Bumps [pyproj](https://github.com/pyproj4/pyproj) from 3.3.1 to 3.4.1. - [Release notes](https://github.com/pyproj4/pyproj/releases) - [Changelog](https://github.com/pyproj4/pyproj/blob/main/docs/history.rst) - [Commits](pyproj4/pyproj@3.3.1...3.4.1) * ⬆️ Bump numpy from 1.22.4 to 1.23.5 Bumps [numpy](https://github.com/numpy/numpy) from 1.22.4 to 1.23.5. - [Release notes](https://github.com/numpy/numpy/releases) - [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst) - [Commits](numpy/numpy@v1.22.4...v1.23.5) * ⬆️ Bump pandas from 1.4.2 to 1.5.3 Bumps [pandas](https://github.com/pandas-dev/pandas) from 1.4.2 to 1.5.3. - [Release notes](https://github.com/pandas-dev/pandas/releases) - [Changelog](https://github.com/pandas-dev/pandas/blob/main/RELEASE.md) - [Commits](pandas-dev/pandas@v1.4.2...v1.5.3) * ⬆️ Bump rasterio from 1.3.2 to 1.3.6 Bumps [rasterio](https://github.com/rasterio/rasterio) from 1.3.0 to 1.3.6. - [Release notes](https://github.com/rasterio/rasterio/releases) - [Changelog](https://github.com/rasterio/rasterio/blob/main/CHANGES.txt) - [Commits](rasterio/rasterio@1.3.0...1.3.6) * ⬆️ Bump fiona from 1.8.21 to 1.9.1 Bumps [fiona](https://github.com/Toblerity/Fiona) from 1.8.21 to 1.9.1. - [Release notes](https://github.com/Toblerity/Fiona/releases) - [Changelog](https://github.com/Toblerity/Fiona/blob/master/CHANGES.txt) - [Commits](Toblerity/Fiona@1.8.21...1.9.1) * ⬆️ Bump pyogrio from 0.4.0 to 0.5.1 Bumps [pyogrio](https://github.com/geopandas/pyogrio) from 0.4.0 to 0.5.1. - [Release notes](https://github.com/geopandas/pyogrio/releases) - [Changelog](https://github.com/geopandas/pyogrio/blob/v0.4.0/CHANGES.md) - [Commits](geopandas/pyogrio@v0.4.0...v0.5.1) * ⬆️ Bump toolz from 0.11.2 to 0.12.0 Bumps [toolz](https://github.com/pytoolz/toolz) from 0.11.2 to 0.12.0. - [Release notes](https://github.com/pytoolz/toolz/releases) - [Changelog](https://github.com/pytoolz/toolz/blob/master/release-notes) - [Commits](pytoolz/toolz@0.11.2...0.12.0) Fixes `AttributeError: 'TlzSpec' object has no attribute '_uninitialized_submodules'`, xref pytoolz/toolz#533 * ⬆️ Bump shapely from 1.8.2 to 2.0.1 Bumps [shapely](https://github.com/shapely/shapely) from 1.8.2 to 2.0.1. - [Release notes](https://github.com/shapely/shapely/releases) - [Changelog](https://github.com/shapely/shapely/blob/2.0.1/CHANGES.txt) - [Commits](shapely/shapely@1.8.2...2.0.1) * 👷 NEP29: Run Continuous Integration on Python 3.11 Bumps [python](https://github.com/python/cpython) from 3.10.10 to 3.11.2. - [Release notes](https://github.com/python/cpython/releases/tag/v3.11.2) - [Changelog](https://docs.python.org/3/whatsnew/3.11.html) - [Commits](python/cpython@v3.10.10...v3.11.2) * 🚩 Skip Ubuntu Python 3.11 CI tests for draft PRs Conserve GitHub Actions Continuous Integration resources when a Pull Request is in draft mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #528.
xref: python/cpython#27338 and python/cpython#88880
I'm a little surprised that the code in CPython assumes that all module specs have
_uninitialized_submodules. Maybe we should push for a change upstream, or maybe we should inherit fromModuleSpecto improve future-compatibility. Actually, yeah, I'll try to just useModuleSpecdirectly instead ofTlzSpec.