TypedDict: Resolve string-based annotations #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we should do this, since get_type_hints() can and will throw errors for some TypedDicts. |
|
It seems like I underestimated the current limitations of Possible cases where it fails:
These are pretty common patterns and I can see that this would be unacceptable. It might be better to evaluate the annotations on a per-item basis with a fallback in case of failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55
I'm calling
typing.get_type_hintsbecausetyping_extensions.get_type_hintsis not yet defined in the relevant section. This shouldn't be a problem as long the behaviour ofget_type_hints(..., include_extras=True)doesn't change. When porting this to thetypingmodule, it should work fine because the definition order is fine there.The test on Python 3.11 fails because
TypedDictis rexported fromtyping(it took some time until I realized that this was the problem :D).