Update typing-extensions README #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JelleZijlstra
commented
Nov 18, 2021
JelleZijlstra
commented
- Add an explicit inclusion policy: new stuff can go in here as soon as there is a PEP
- Remove obsolete discussion of the typing PyPI package
- Organize the list of contents by Python version, so it's easier to find the interesting bits. Maybe we should deprecate the stuff that was new in 3.5/3.6 at some point.
- Add an explicit inclusion policy: new stuff can go in here as soon as there is a PEP - Remove obsolete discussion of the typing PyPI package - Organize the list of contents by Python version, so it's easier to find the interesting bits. Maybe we should deprecate the stuff that was new in 3.5/3.6 at some point.
JelleZijlstra
commented
Nov 18, 2021
|
|
||
| - ``OrderedDict`` | ||
|
|
||
| - In ``typing`` since Python 3.5 or 3.6 (see `the typing documentation |
There was a problem hiding this comment.
Separating out 3.5 and 3.6 is hard because things were added in patch releases (for example, ChainMap was new in 3.5.4 and 3.6.1). Listing out all the details about that doesn't seem useful.
There was a problem hiding this comment.
Especially since we don't support 3.5 anymore.
hauntsaninja
approved these changes
Nov 18, 2021
| in a PEP that has been added to the `python/peps <https://github.com/python/peps>`_ | ||
| repository. If the PEP is accepted, the feature will then be added to ``typing`` | ||
| for the next CPython release. No typing PEP has been rejected so far, so we | ||
| haven't yet figured out how to deal with that possibility. |
There was a problem hiding this comment.
Maybe we'll remove it in the next major version. But I have no strong feelings regarding this.
There was a problem hiding this comment.
That makes sense to me too, but we can figure that out when we get to it.
srittau
approved these changes
Nov 19, 2021
srittau
pushed a commit
to srittau/typing
that referenced
this pull request
Dec 2, 2021
- Add an explicit inclusion policy: new stuff can go in here as soon as there is a PEP - Remove obsolete discussion of the typing PyPI package - Organize the list of contents by Python version, so it's easier to find the interesting bits. Maybe we should deprecate the stuff that was new in 3.5/3.6 at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.