Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up typing_extensions -- typing_extensions #932

Merged
merged 32 commits into from Nov 11, 2021
Merged

Clean-up typing_extensions -- typing_extensions #932

merged 32 commits into from Nov 11, 2021

Conversation

AA-Turner
Copy link
Member

xref #892
@srittau

Actual typing_extensions PR. Unchanged from original.

A

srittau
srittau requested changes Nov 11, 2021
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

You (sensibly) removed a few non-underscored, but also not exported via __all__ attributes. As this is technically an API change (even though it's not exported via __all__), could you add these removals to typing_extensions/CHANGELOG:

  • TypingMeta
  • OLD_GENERICS
  • SUBS_TREE
  • HAVE_ANNOTATED
  • HAVE_PROTOCOLS

Also could you mention in the Changelog that starting with 4.0.0 support for Python 2 and <3.6 has been dropped?

A few more remarks below.

typing_extensions/src_py3/typing_extensions.py Outdated Show resolved Hide resolved
typing_extensions/src_py3/typing_extensions.py Outdated Show resolved Hide resolved
typing_extensions/src_py3/typing_extensions.py Outdated Show resolved Hide resolved
@AA-Turner
Unconditional _collections_abc._check_methods import
297017d
@AA-Turner
HAVE_PROTOCOLS is True on all supported versions
aef48a2
@AA-Turner
Remove sys.version_info gates on unsupported versions
6c60077
@AA-Turner
Remove TYPING_3_5_* gates
f32c280
@AA-Turner
Remove SUBCLASS_CHECK_FORBIDDEN gates
2c4e79f
@AA-Turner
Remove ASYNCIO gates
a7fbda3
@AA-Turner
Remove PY36 gates
011cfb6
@AA-Turner
Remove HAVE_PROTOCOLS gate
87a9e10
@AA-Turner
Remove remaining sys.version_info gates
ab64fc9
@AA-Turner
Address flake8 warnings
14236e8
@AA-Turner
Unconditionally import where possible
406c807
@AA-Turner
_geqv was removed in Python 3.6
5579ed8
@AA-Turner
Unconditionally define values where possible
93b0a7d
@AA-Turner
Remove now unused _define_guard
d3dcbcc
@AA-Turner
Remove OLD_GENERICS
ea6657a
@AA-Turner
Use f-strings
ccdcb44
@AA-Turner
Use new style super()
f0bad77
@AA-Turner
Names will always exist
d9f613f
@AA-Turner
Use f-strings in tests
dafcd01
@AA-Turner
Use !r in f-strings
b18d1e7
@AA-Turner
Inline _generic_new
e0af14f
@AA-Turner
Inline typing imports
8df7fdf
@AA-Turner
Remove unused type variables
eda545a
@AA-Turner
Localise helper imports
38cbc89
@AA-Turner
Pick up unchanged .formats -> f-strings
14c8165
@AA-Turner
Inline TypingMeta
f03471f
@AA-Turner
Swap Protocol definitions for 3.6 and 3.7 for consistency with all ot…
307544b 
…hers
@AA-Turner
Inline _tp_cache, _TypingEllipsis, _TypingEmpty
ef763f1
@AA-Turner
Copy link
Member Author

Sorry, forgot to add a changelog entry earlier -- have now done so.

srittau
srittau approved these changes Nov 11, 2021
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again. For future reference: Please don't force push as it makes it harder to review changes.

@AA-Turner
Copy link
Member Author

Sorry - I had to rebase onto master to pick up the changelog -- is it better to merge in HEAD instead of rebase + force push?
A

@srittau srittau merged commit 6992984 into python:master Nov 11, 2021
@srittau
Copy link
Collaborator

srittau commented Nov 11, 2021

Yes, we squash merge anyway, so rebasing should not be necessary.

@srittau srittau mentioned this pull request Nov 11, 2021
Merged
@AA-Turner AA-Turner deleted the cleanup-typing-extensions branch November 11, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AA-Turner @srittau @the-knights-who-say-ni