Clean-up typing_extensions -- meta
#931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
changed the title
typing_extensions -- metatyping_extensions -- meta
JelleZijlstra
approved these changes
Nov 11, 2021
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
srittau
approved these changes
Nov 11, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #892
@srittau
'Meta' PR with build changes -- note changed from the original PR as I saw setuptools intend to deprecate and remove
setup.py installandpyproject.tomlis the blessed solution. I was going to use setuptools as the backend for consistency but it fails on windows due to encoding problems (setuptools uses encoding=None when reading config files, and the default windows code page isn't UTF-8) with Łukasz's name -- flit seems to have no such problems, and was the first alternative when I searched for non-setuptools backends.A