Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_overloads() #1140

Merged
merged 5 commits into from Apr 16, 2022
Merged

Add get_overloads() #1140

merged 5 commits into from Apr 16, 2022

Conversation

JelleZijlstra
Copy link
Member

I just merged python/cpython#31716 to provide these functions in 3.11.

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JelleZijlstra JelleZijlstra merged commit 35dff91 into python:master Apr 16, 2022
@JelleZijlstra JelleZijlstra deleted the getoverloads branch April 16, 2022 17:11
JelleZijlstra added a commit to JelleZijlstra/mypy that referenced this pull request Apr 16, 2022
This always existed, but was an alias for typing.overload. With
python/typing#1140, it will actually make a difference at runtime
which one you use.
hauntsaninja pushed a commit to python/mypy that referenced this pull request Apr 16, 2022
This always existed in typing_extensions, but was an alias for
typing.overload. With python/typing#1140, it will actually make
a difference at runtime which one you use.

Note that this shouldn't change mypy's behaviour, since
we alias typing_extensions.overload to typing.overload
in typeshed, but this makes the logic less fragile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants