Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python 3.7.1 and run more versions in CI #1076

Merged
merged 4 commits into from
Feb 14, 2022
Merged

Fix Python 3.7.1 and run more versions in CI #1076

merged 4 commits into from
Feb 14, 2022

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Feb 14, 2022 •
edited

@JelleZijlstra
Copy link
Member Author

Looks like it's only 3.7.1 :D

@JelleZijlstra JelleZijlstra mentioned this pull request Feb 14, 2022
Closed
@JelleZijlstra
Copy link
Member Author

The failing test is because python/cpython#9750 wasn't applied to 3.7.1 yet. I don't know how to fix that one without even more monkey patching, and nobody has complained about this directly yet, so I'm going to just skip that test on 3.7.1.

@JelleZijlstra JelleZijlstra changed the title run more versions in CI Fix Python 3.7.1 and run more versions in CI Feb 14, 2022
hauntsaninja
hauntsaninja approved these changes Feb 14, 2022
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both for the fast fixes!

Interesting GA doesn't have some of the earlier versions. I assume that's just because they predate GA and not because they remove them.

@hauntsaninja hauntsaninja merged commit 83ed5bf into python:master Feb 14, 2022
@JelleZijlstra JelleZijlstra deleted the unpackalias branch February 14, 2022 03:10
@hauntsaninja
Copy link
Collaborator

Btw, looks like tests are failing on 3.11, not sure if that's expected

@JelleZijlstra
Copy link
Member Author

I assume that's just because they predate GA and not because they remove them.

That was my guess too. Thanks for the merge (and thanks @sobolevn for the initial PR)!

@JelleZijlstra
Copy link
Member Author

The 3.11 thing is because GH Actions's 3.11 is outdated, so @GBeauregard's fix for P.args equality isn't in yet. It should be OK with the next alpha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.1.0 error after relase in 2022.02.13 NameError: name '_UnpackAlias' is not defined
3 participants
@JelleZijlstra @hauntsaninja @the-knights-who-say-ni