Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotated: backport bpo-46491 #1049

Merged
merged 4 commits into from Jan 25, 2022
Merged

Annotated: backport bpo-46491 #1049

merged 4 commits into from Jan 25, 2022

Conversation

GBeauregard
Copy link
Contributor

This allows Annotated to wrap ClassVar and Final.

https://bugs.python.org/issue46491

JelleZijlstra
JelleZijlstra requested changes Jan 25, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just some small feedback

typing_extensions/src/typing_extensions.py Outdated Show resolved Hide resolved
typing_extensions/CHANGELOG Outdated Show resolved Hide resolved
@JelleZijlstra
Copy link
Member

We could provide typing_extensions.Annotated on 3.9 and 3.10 to provide a version with the fix immediately, but I'm not sure that's worth it in this case. Alternatively, we can just skip the 3.9 and 3.10 tests until the next bugfix release.

@GBeauregard
Copy link
Contributor Author

We could provide typing_extensions.Annotated on 3.9 and 3.10 to provide a version with the fix immediately, but I'm not sure that's worth it in this case. Alternatively, we can just skip the 3.9 and 3.10 tests until the next bugfix release.

Is this okay?
@skipIf(sys.version_info[:2] in ((3, 9), (3, 10)), "Waiting for bugfix release.")

@JelleZijlstra
Copy link
Member

Yes, let's do that

@JelleZijlstra JelleZijlstra merged commit 3b53f01 into python:master Jan 25, 2022
@GBeauregard GBeauregard deleted the backport-46491 branch February 8, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GBeauregard @JelleZijlstra @the-knights-who-say-ni