Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stubtest failed on Sat Mar 05 2022 #7441

Closed
github-actions bot opened this issue Mar 5, 2022 · 5 comments
Closed

Stubtest failed on Sat Mar 05 2022 #7441

github-actions bot opened this issue Mar 5, 2022 · 5 comments

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2022

Stubtest runs are listed here: https://github.com/python/typeshed/actions/workflows/stubtest.yml
@AlexWaygood
Copy link
Member

Many, many failures.

@hauntsaninja hauntsaninja mentioned this issue Mar 5, 2022
Merged
@hauntsaninja
Copy link
Collaborator

I'm reverting checking positional-only differences on dunders in python/mypy#12293, as previously discussed in #7344 (comment)
There are other failures, but these are the majority and the busy-work-est of them.

This way we keep typeshed and stubtest master in a mostly reconcilable state and we can then ship improvements at our leisure.

hauntsaninja added a commit to python/mypy that referenced this issue Mar 5, 2022
@hauntsaninja
Revert "stubtest pos-only differences in dunders (#12184)" (#12293)
b3752a6 
This reverts commit 777885f.

To help with python/typeshed#7441 and reduce risk of stubtest issues interfering with a mypy release. The extra type correctness here is really minimal.

Co-authored-by: hauntsaninja <>
@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Mar 5, 2022 •
edited

I misdiagnosed a little bit, looks like some of the positional-only differences was something stubtest always reported, but interacts a little unfortunately with python/mypy#12203.

python/mypy#12294 changes things to ignore those as well.

Once typeshed CI is green, we can look into potentially reverting python/mypy#12293 and python/mypy#12294. In particular, I think one way forward is to not check for positional-only differences in the case where stub inherits the relevant dunder.

@AlexWaygood
Copy link
Member

In particular, I think one way forward is to not check for positional-only differences in the case where stub inherits the relevant dunder.

I like this idea a lot :)

@hauntsaninja
Copy link
Collaborator

Green again! https://github.com/python/typeshed/actions/workflows/daily.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hauntsaninja @AlexWaygood