Fix type errors stemming from getattr #9889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes python#9888 I applied the following patch to typeshed and ran self check: ``` +@overload +def getattr(__o: Any, name: str, __default: None) -> Optional[Any]: ... +@overload def getattr(__o: Any, name: str, __default: Any = ...) -> Any: ... ```
hauntsaninja
pushed a commit
to hauntsaninja/typeshed
that referenced
this pull request
Jan 7, 2021
This found a couple issues in mypy (see python/mypy#9889)
JukkaL
reviewed
Jan 7, 2021
mypy/moduleinspect.py
Outdated
| @@ -45,7 +45,7 @@ def get_package_properties(package_id: str) -> ModuleProperties: | |||
| package = importlib.import_module(package_id) | |||
| except BaseException as e: | |||
| raise InspectError(str(e)) from e | |||
| name = getattr(package, '__name__', None) | |||
| name = package.__name__ | |||
There was a problem hiding this comment.
I don't think that this is safe, since all sorts of objects can be stuffed into sys.modules, and there's no guarantee that there's a __name__ attribute, as far as I can tell. I think it would be better to default to package_id as the name if there's no __name__.
|
Thanks, fixed! Yeah, that's the overload I used to find these. You can also use the overload Unfortunately, mypy_primer finds both potential typeshed changes somewhat problematic so I'm going to hold off (at least until we're back to having a release cycle) |
JukkaL
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9888
I applied the following patch to typeshed and ran self check: