Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypyc] Respect declared metaclasses for non-extension classes #8119

Merged
merged 2 commits into from Dec 10, 2019
Merged

[mypyc] Respect declared metaclasses for non-extension classes #8119

merged 2 commits into from Dec 10, 2019

Conversation

msullivan
Copy link
Collaborator

No description provided.

JukkaL
JukkaL approved these changes Dec 10, 2019
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just noticed one debug print.

mypyc/genops.py Outdated
def find_non_ext_metaclass(self, cdef: ClassDef, bases: Value) -> Value:
"""Find the metaclass of a class from its defs and bases. """
if cdef.metaclass:
print(cdef.metaclass)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a debug print.

@msullivan msullivan merged commit 7e65f1e into master Dec 10, 2019
@msullivan msullivan deleted the metaclass branch December 10, 2019 19:26
@AlexWaygood AlexWaygood mentioned this pull request Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msullivan @JukkaL