Stubgen: split @abstractproperty #8066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TH3CHARLie
commented
Dec 3, 2019
TH3CHARLie
commented
Dec 3, 2019
| elif self.refers_to_fullname(name, 'abc.abstractproperty'): | ||
| self.add_decorator('property') | ||
| self.add_decorator('abc.abstractmethod') | ||
| is_abstract = True |
There was a problem hiding this comment.
I'd like to be more specific about here. (The previous commit has incorrect tests)
I intentionally did not require_name in import_tracker. This is because is_abstract will be set and abc will be imported, so directly add abc.abstractmethod would work. And as shown in testcase: testAbstractProperty3_semanal, if the imported abstractproperty is aliased, to properly split would have to modify code in import_tracker, which IMO is not necessary since using abc.abstractmethod already achieves purposes
TH3CHARLie
changed the title
Closed
msullivan
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7952