Increment lambda_counter #7889
Merged
Increment lambda_counter #7889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
reviewed
Nov 6, 2019
There was a problem hiding this comment.
Good catch. That is a pretty silly bug.
Could you update one of the run tests instead of a genops test, though? I'm pretty likely to delete like 90% of the genops tests at some point so I don't want to have genops tests for anything where we don't specifically care about what IR is generated.
|
Eh whatever |
|
Oh right my request made no sense, also, since it is fundamentally a genops thing. tbh maybe it isn't worth testing though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, with multiple lambdas, the second one would be named like
__mypyc_lambda__0_f_obj_0, since the counter didn't increment. Now, the second one is named like__mypyc_lambda__1_f_obj.