New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix __init_subclass__ type check #7723

Merged

msullivan merged 1 commit into python:master from ilevkivskyi:fix-typeddict-init-subclass

Oct 16, 2019

Member

ilevkivskyi commented Oct 16, 2019

Fixes #7722

This skips checking class keywords against __init_subclass__ for:

Classes with custom metaclasses, because they can pop the keywords before calling super().
Classes that are special forms, like TypedDict etc.


          Fix __init_subclass__ type check

8a2de9f

ilevkivskyi requested a review from msullivan

October 16, 2019 13:35

Collaborator

msullivan commented Oct 16, 2019

Yeah, good catch. This will get cherry picked.

msullivan merged commit 222b14d into python:master

msullivan pushed a commit that referenced this pull request


          Fix __init_subclass__ type check (#7723)

97d25cf

tdamsma mentioned this pull request

Regression in 0.740 for __init__subclass__ #7735

Closed

esoma mentioned this pull request

metaclass/__init_subclass__ keyword checking #11057

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment