Always show the cause of error in dmypy suggest #7680
Conversation
There was a problem hiding this comment.
Showing errors should improve usability significantly, especially if there are 'fixme' types. Will the PyCharm mypy plugin be able to show the errors using the nice UX which allows quickly jumping to an error location?
If/when we document dmypy suggest, having colors could be worth it, but now this seems good enough to let us experiment with it.
mypy/suggestions.py
Outdated
| if check_errors and res: | ||
| raise SuggestionFailure("Error while trying to load %s" % state.id) | ||
| # TODO: apply color and formatting to error messages? | ||
| raise SuggestionFailure("Error while trying to load %s:\n" % state.id + '\n'.join(res)) |
There was a problem hiding this comment.
Nit: The term 'load' here seems a bit inconsistent to me. What about "Error while processing..."? Or maybe leave the header out altogether -- just having the error messages should be clear enough.
There was a problem hiding this comment.
I will replace it with "Error while processing..."
I think so, it redirects stderr to stdout before parsing it (also it ignores every line without |
This PR prints the type errors that prevented
dmypy suggestfrom running. Since this will be mostly used by interactive tools, I don't pipe the errors though normal formatting and colors, but if you think it makes sense, then I can do this.