Fix operator error messages for __div__ and __cmp__ on python 2 #7671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the code for turning method call errors into operator error messages doesn't detect __div__ and __cmp__, so fix that. One of my main motivations here is that this fixes type ignoring these with an error code, since previously the real error would be `arg-type` but the note would be `operator`.
Michael0x2a
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code for turning method call errors into operator error
messages doesn't detect div and cmp, so fix that.
One of my main motivations here is that this fixes type ignoring these
with an error code, since previously the real error would be
arg-typebut the note would beoperator.I think that longer term it is probably worth having notes automatically take
the error code of the most recent error, or some such, but that is probably worth some discussion.
I'd like to get this into the release #7638