Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove new_semantic_analyzer from config parameters #7529

Merged
merged 3 commits into from Oct 11, 2019
Merged

Remove new_semantic_analyzer from config parameters #7529

merged 3 commits into from Oct 11, 2019

Conversation

onlined
Copy link
Contributor

@onlined onlined commented Sep 18, 2019 •
edited

Fixes #7523.

@onlined
Copy link
Contributor Author

onlined commented Sep 20, 2019

I forgot about new_semantic_analyzer being a property, so identity comparison doesn't work with it. I will solve the problem.

JukkaL
JukkaL approved these changes Oct 11, 2019
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@JukkaL JukkaL merged commit 4510a0b into python:master Oct 11, 2019
@JukkaL JukkaL mentioned this pull request Oct 11, 2019
Closed
msullivan pushed a commit that referenced this pull request Oct 11, 2019
@onlined @msullivan
Remove new_semantic_analyzer from config parameters (#7529)
9751449 
Fixes #7523.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new_semantic_analyzer = ... raises AttributeError
2 participants
@onlined @JukkaL