Support pickling of extension classes #7481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 7, 2019
ilevkivskyi
approved these changes
Sep 9, 2019
This operates by providing default implementations of `__getstate__` and `__setstate__` for extension classes. Our implementations work by storing a `__mypyc_attrs__` tuple in each class that we generate and collecting all of the attributes in it into a dict. Fixes #697.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This operates by providing default implementations of
__getstate__and
__setstate__for extension classes. Our implementations work bystoring a
__mypyc_attrs__tuple in each class that we generate andcollecting all of the attributes in it into a dict.
This is is the last big obstacle to supporting black well.
Fixes mypyc/mypyc#697.