Point error to incompatible argument instead of call expression #7470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we just pointed to the beginning of the call expression, which is not great if there are multiple arguments. Also point to incompatible list/dict/set item instead of the beginning of a list/dict/set expression. Note that this may require some `# type: ignore` comments to be updated.
ilevkivskyi
approved these changes
Sep 5, 2019
| CallableType, | ||
| Context, | ||
| Context, | ||
| MessageBuilder], |
mypy/checkexpr.py
Outdated
| @@ -1169,7 +1178,8 @@ def check_argument_count(self, | |||
| if messages: | |||
| assert context, "Internal error: messages given without context" | |||
| elif context is None: | |||
| context = TempNode(AnyType(TypeOfAny.special_form)) # Avoid "is None" checks | |||
| # Avoid "is None" checks | |||
| context = TempNode(AnyType(TypeOfAny.special_form), context=context) | |||
There was a problem hiding this comment.
context=context is redundant since it is anyway None.
|
It looks like you also need to update the |
|
Also note that on Python 3.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we pointed to the beginning of the call expression if there
was an incompatible argument, which is not great, particularly if there
are multiple arguments.
Also point to incompatible list/dict/set item instead of the beginning
of a list/dict/set expression.
Note that this may require some
# type: ignorecomments to beupdated.
I had to update the output of many test cases, mostly because line
ordering was changed.