Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable new semantic analyzer by default #7174

Merged
merged 2 commits into from Jul 9, 2019
Merged

Enable new semantic analyzer by default #7174

merged 2 commits into from Jul 9, 2019

Conversation

ilevkivskyi
Copy link
Member

The old semantic analyzer is still there and can be used with --no-new-semantic-analyzer. For running tests one can use NEWSEMANAL=0.

@ilevkivskyi ilevkivskyi requested a review from JukkaL July 8, 2019 18:15
msullivan
msullivan approved these changes Jul 9, 2019
View reviewed changes
Copy link
Collaborator

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it

@ilevkivskyi ilevkivskyi merged commit dc58be0 into python:master Jul 9, 2019
@ilevkivskyi ilevkivskyi deleted the make-newan-default branch July 9, 2019 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msullivan msullivan msullivan approved these changes

@JukkaL JukkaL Awaiting requested review from JukkaL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ilevkivskyi @msullivan