Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test running dmypy compiled on Windows before a release #7034

Open
JukkaL opened this issue Jun 21, 2019 · 2 comments
Open

Test running dmypy compiled on Windows before a release #7034

JukkaL opened this issue Jun 21, 2019 · 2 comments
Assignees
@ethanhs
Labels
priority-0-high topic-daemon dmypy topic-tests

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Jun 21, 2019 •
edited

dmypy was broken in the 0.710 release on Windows and our CI didn't catch it. See #7031 for the issue. It would be good to have CI find issues like this. Alternatively, we could add an extra step to our release process, but that would be unfortunate unless we can automate it.
@ethanhs ethanhs self-assigned this Sep 5, 2019
@ethanhs
Copy link
Collaborator

ethanhs commented Sep 5, 2019

So I suppose the best thing to do would be to conditionally build and run the tests on dmypy on tags, as that would not require running the test suite twice every commit. I can work on that this weekend.

@ilevkivskyi
Copy link
Member

@ethanhs I think this makes sense.

@JukkaL JukkaL mentioned this issue Dec 5, 2019
Closed
@AlexWaygood AlexWaygood added the topic-daemon dmypy label Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanhs ethanhs

Labels
priority-0-high topic-daemon dmypy topic-tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JukkaL @ethanhs @ilevkivskyi @AlexWaygood