Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document --new-semantic-analyzer #7023

Merged
merged 4 commits into from Jun 19, 2019
Merged

Document --new-semantic-analyzer #7023

merged 4 commits into from Jun 19, 2019

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Jun 19, 2019

The "next mypy release" in the text refers to the next release after
0.710.

@JukkaL JukkaL requested a review from gvanrossum June 19, 2019 16:27
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up!


The next mypy release will use the new semantic analyzer by
default, and the old semantic analyzer will be removed in the next
release after that.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use the actual expected release numbers instead of "next" and "next after that"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not, since we may change our mind about that. However I would like to hedge a bit by adding "Likely, ...".

@gvanrossum gvanrossum merged commit 561b9e7 into master Jun 19, 2019
@gvanrossum gvanrossum deleted the doc-new-sem-anal branch June 19, 2019 17:51
gvanrossum pushed a commit that referenced this pull request Jun 19, 2019
PattenR pushed a commit to PattenR/mypy that referenced this pull request Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants