Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for running with 3.4 #6592

Merged
merged 4 commits into from Mar 27, 2019
Merged

Drop support for running with 3.4 #6592

merged 4 commits into from Mar 27, 2019

Conversation

ethanhs
Copy link
Collaborator

@ethanhs ethanhs commented Mar 26, 2019

Fixes #6564

This PR was a bit larger than I expected, but after the test failure in #6591 I am keen to move forward with dropping support for 3.4.

@ethanhs ethanhs mentioned this pull request Mar 26, 2019
Closed
JukkaL
JukkaL reviewed Mar 26, 2019
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's great to be able to drop 3.4 workarounds. I found a few remaining 3.4 references that should probably be updated in tox.ini.

gvanrossum
gvanrossum reviewed Mar 26, 2019
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but see Jukka's comment about tox.

I also found references to 3.3 (!) in fastparse.py and fastparse2.py.

gvanrossum
gvanrossum approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried to run it with 3.4? Does it even make it to that error message? For all entry points?

msullivan
msullivan reviewed Mar 26, 2019
View reviewed changes
mypy/util.py Outdated Show resolved Hide resolved
@ethanhs
Copy link
Collaborator Author

ethanhs commented Mar 26, 2019

Have you tried to run it with 3.4? Does it even make it to that error message? For all entry points?

Yes I checked this in a docker container with 3.4.10, it does indeed cause the error to be shown.

I tested mypy,dmypy, and stubgen.

gvanrossum
gvanrossum approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@ethanhs ethanhs merged commit affb032 into python:master Mar 27, 2019
@ethanhs ethanhs deleted the drop34 branch March 27, 2019 02:58
@sebmartin sebmartin mentioned this pull request Apr 10, 2019
Merged
@astrojuanlu astrojuanlu mentioned this pull request Jul 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msullivan msullivan msullivan left review comments

@JukkaL JukkaL JukkaL left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ethanhs @msullivan @JukkaL @gvanrossum