Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for error/hint location #4829

Closed
ilevkivskyi opened this issue Mar 29, 2018 · 1 comment
Closed

Better support for error/hint location #4829

ilevkivskyi opened this issue Mar 29, 2018 · 1 comment

Comments

@ilevkivskyi
Copy link
Member

In view of planned editor integration support I think there are two important things to do in addition to fixing relevant high-priority issues like #3871 that require updating typed_ast:

  • Make a thorough walk through the code and fix all places where column is not set correctly, there are still quite a few such places I think, see also Check coulmn numbers in existing tests #4276.
  • Design an API to quickly find a node object by file name, line number, and column. This will be needed at later stages when we will need to return type of a node (or some other info like accessible attributes) by request from the editor.
@JukkaL
Copy link
Collaborator

JukkaL commented Jan 29, 2020

Column numbers are now set pretty reliably already (#7053). The second goal is no longer a priority (but it's possible that we'll revisit the idea at some point in the future).

@JukkaL JukkaL closed this as completed Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants