Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on deferred value constrained TypeVar #14642

Merged
merged 2 commits into from Feb 8, 2023
Merged

Fix crash on deferred value constrained TypeVar #14642

merged 2 commits into from Feb 8, 2023

Conversation

hauntsaninja
Copy link
Collaborator

Fixes #14631

@hauntsaninja
Copy link
Collaborator Author

Is it worth adding tuple(self.values) in the __hash__?

@hauntsaninja hauntsaninja mentioned this pull request Feb 8, 2023
Closed
17 tasks
@github-actions

This comment has been minimized.

Sign in to view
@ronf ronf mentioned this pull request Feb 8, 2023
Closed
ilevkivskyi
ilevkivskyi approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should be in hash as well.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninja hauntsaninja merged commit 786c7b0 into python:master Feb 8, 2023
@hauntsaninja hauntsaninja deleted the value-crash branch February 8, 2023 19:51
ilinum pushed a commit to ilinum/mypy that referenced this pull request Feb 8, 2023
@hauntsaninja @ilinum
Fix crash on deferred value constrained TypeVar (python#14642)
a7b124a 
Fixes python#14631
ilinum added a commit that referenced this pull request Feb 9, 2023
@ilinum @hauntsaninja
[backport] Fix crash on deferred value constrained TypeVar (#14642) (#…
0c99585 
…14655)

Fixes #14631

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"unresolved placeholder type None" on mypy 1.0.0
2 participants
@hauntsaninja @ilevkivskyi