Don't ignore errors in files passed on the command line #14060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that were under a directory in `sys.path`, which sometimes includes the current working directory, resulting in no errors reported at all. Fixes #14042.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
svalentin
pushed a commit
that referenced
this pull request
Nov 10, 2022
#13768 had a bug so that errors were sometimes silenced in files that were under a directory in `sys.path`. `sys.path` sometimes includes the current working directory, resulting in no errors reported at all. Fix it by always reporting errors if a file was passed on the command line (unless *explicitly* silenced). When using import following errors can still be ignored, which is questionable, but this didn't change recently so I'm not addressing it here. Fixes #14042.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13768 had a bug so that errors were sometimes silenced in files that were under a
directory in
sys.path.sys.pathsometimes includes the current working directory,resulting in no errors reported at all. Fix it by always reporting errors if a file was passed
on the command line.
When using import following errors can still be ignored, which is questionable, but
this didn't change recently so I'm not addressing it here.
Fixes #14042.