Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on inference with recursive alias to recursive instance #14038

Merged
merged 1 commit into from Nov 8, 2022
Merged

Fix crash on inference with recursive alias to recursive instance #14038

merged 1 commit into from Nov 8, 2022

Conversation

ilevkivskyi
Copy link
Member

Fixes #14031

It turns out premature optimization is the root of all evil. (It turns out this costs us less than 1% time on self-check).

@ilevkivskyi ilevkivskyi mentioned this pull request Nov 8, 2022
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

JukkaL
JukkaL approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@JukkaL JukkaL merged commit fa22a49 into python:master Nov 8, 2022
@ilevkivskyi ilevkivskyi deleted the fix-rec-inf-crash branch November 8, 2022 15:55
svalentin pushed a commit that referenced this pull request Nov 8, 2022
@ilevkivskyi @svalentin
Fix crash on inference with recursive alias to recursive instance (#1…
131c8d7 
…4038)

Fixes #14031 

It turns out premature optimization is the root of all evil. (It turns
out this costs us less than 1% time on self-check).
@hauntsaninja hauntsaninja mentioned this pull request Nov 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mypy 0.990 crashes with segmentation fault on hydra_zen due to recursive types
2 participants
@ilevkivskyi @JukkaL