Update pos-only unit tests for Python 3.10.7 #13660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
approved these changes
Sep 13, 2022
|
(looks like CI is running with 3.10.6 so I'm just gonna trust that you got everything) |
It surprised me that it didn't! But also it's consistent with |
I fixed all the ones I found in failing CI runs, but then I just tried upgrading to Python 3.10.7 locally, and I found a bunch more 🤷♂️. I've just updated the PR to fix those as well. |
AlexWaygood
commented
Sep 13, 2022
cdce8p
pushed a commit
to cdce8p/mypy
that referenced
this pull request
Sep 14, 2022
…#13660) The CI has started to sporadically fail depending on whether 3.10.6 is picked up by GitHub Actions (okay) or 3.10.7 (not okay). For example: - https://github.com/python/mypy/actions/runs/3046671132/jobs/4909772702 - https://github.com/python/mypy/actions/runs/3046723692/jobs/4909887963 On Python 3.10.7 (but not on Python 3.10.6), mypy correctly rejects using PEP 570 syntax unless `--python-version` is set to 3.8 or higher (this is due to python/cpython#95935). However, this makes several unit tests fail. This PR updates those unit tests so that the CI passes on both 3.10.6 and 3.10.7
hauntsaninja
pushed a commit
that referenced
this pull request
Sep 14, 2022
#13665) Backport #13660 to fix test issues with Python 3.10.7. https://github.com/python/mypy/actions/runs/3046723692/jobs/4909887963 Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CI has started to sporadically fail depending on whether 3.10.6 is picked up by GitHub Actions (okay) or 3.10.7 (not okay). For example:
On Python 3.10.7 (but not on Python 3.10.6), mypy correctly rejects using PEP 570 syntax unless
--python-versionis set to 3.8 or higher (this is due to python/cpython#95935). However, this makes several unit tests fail.This PR updates those unit tests so that the CI passes on both 3.10.6 and 3.10.7