Positional-only parameters with python 3.10.7 (and numpy) (fixed in 0.981) #13627

sodul · 2022-09-08T10:51:46Z

Bug Report

After upgrading to python 3.10.7 from 3.10.6 mypy is reporting errors on numpy .pyi files when positional only parameters syntax is present. This error should only get triggered when using versions of python older than 3.8. After rolling back to python 3.10.6 no errors are being reported.

To Reproduce

(Write your steps here:)

mypy something_using_numpy.py

Expected Behavior

It should pass without any problem

Actual Behavior

/Users/stephane/.pyenv/versions/3.10.7/lib/python3.10/site-packages/numpy/__init__.pyi:636:48: error: Positional-only parameters are only supported in Python 3.8 and greater  [syntax]
Found 1 error in 1 file (errors prevented further checking)

Your Environment

mypy==0.971
Mypy command-line flags: none
Mypy configuration options:

python_version=3.10
sqlite_cache=True
namespace_packages=True
ignore_missing_imports=True
follow_imports=silent
show_column_numbers=True
check_untyped_defs=True
show_error_codes=True

Python 3.10.7 (3.10.6 is working fine).
macOS 12.5.1, Apple CPU
numpy==1.23.2

The text was updated successfully, but these errors were encountered:

michael-k · 2022-09-08T10:59:16Z

This might be related to

[:func:`ast.parse`](https://github.com/python/cpython/blob/v3.10.7/Misc/NEWS.d/3.10.7.rst#id13)
will no longer parse function definitions with positional-only params when passed feature_version
less than (3, 8). Patch by Shantanu Jain.

Source: https://github.com/python/cpython/blob/v3.10.7/Misc/NEWS.d/3.10.7.rst

Related pull requests/issues:

issue: ast.parse allows positional-only params with old feature_version cpython#94996
PR against main: gh-94996: Disallow parsing pos only param with feature_version < (3, 8) cpython#94997
PR against Python 3.10: [3.10] gh-94996: Disallow parsing pos only params with feature_version < (3, 8) cpython#95935

michael-k · 2022-09-08T11:21:31Z

Looks like this was already fixed in #13500 (unreleased)

AlexWaygood · 2022-09-08T15:53:43Z

Yup, a mypy release with the fix will be out soon (might be included in mypy 0.980, if not it will be in mypy 0.990).

Edit: fix was included in 0.981 and newer

To work around python/mypy#13627

atugushev · 2022-09-13T15:53:42Z

Any known workaround for this?

AlexWaygood · 2022-09-13T15:55:54Z

Any known workaround for this?

Pin Python to 3.10.6 (not 3.10.7).

* Try alternative xxhash implementation Hopefully it can compile on non-x86 arch * Pin formatting CI python version To work around python/mypy#13627 * Revert adding pypy to builds * Add includes in makefile as well

It seems that there is a bug with mypy and python 3.10.7: "After upgrading to python 3.10.7 from 3.10.6 mypy is reporting errors on numpy .pyi files when positional only parameters syntax is present. This error should only get triggered when using versions of python older than 3.8. After rolling back to python 3.10.6 no errors are being reported." python/mypy#13627

* Remove tornado submodule * Rename packages/stlite-kernel to packages/kernel * Add submodule packages/kernel/py/tornado * Replace @stlite/stlite-kernel usage with @stlite/kernel * Replace stlite-kernel with kernel in the CI workflows * Update mypy due to python/mypy#13627

Running the linting with the latest image fails as it raises issues with mypy See: python/mypy#13627 Change-Id: I98bb6e713f3e32d7dae0ca0398a3e7632e0e886d

The older MyPy version had a bug. See python/mypy#13627

python/mypy#13627 now causes spurious errors involving numpy but another type issue is solved.

hauntsaninja · 2022-10-13T21:13:22Z

If you're running into this, use mypy 0.981 or newer or downgrade to Python 3.10.6

Fixes python/mypy#13627

Needed this bug to be fixed: python/mypy#13627 This also incidentally fixed the mypy bug in csv_exporter.py

* Python 3.10 Performance gains go brrr * Add missing SAML deps * Add missing dep to dockerfile * Update mypy to 0.981 for 3.10.7 compatibility Needed this bug to be fixed: python/mypy#13627 This also incidentally fixed the mypy bug in csv_exporter.py * bump to 3.10.10

sodul added the bug mypy got something wrong label Sep 8, 2022

AlexWaygood closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2022

This was referenced Sep 8, 2022

Mypy in 3.10 does not respect the python version when checking .pyi files #13635

Closed

Mypy (running in 3.10) complains that positional-only parameters are only supported in 3.8+ #13639

Closed

hauntsaninja pinned this issue Sep 9, 2022

AlexWaygood mentioned this issue Sep 9, 2022

latest numpy is failing build with "syntax error" that cannot be disabled #13642

Closed

hauntsaninja changed the title ~~Positional-only parameters error with python 3.10.7~~ Positional-only parameters error with python 3.10.7 (and numpy) Sep 9, 2022

hauntsaninja mentioned this issue Sep 9, 2022

MyPy Reporting problems in dependencies (site-packages) #12162

Open

ribeaud mentioned this issue Sep 13, 2022

Positional-only parameters are only supported in Python 3.8 and greater pandas-dev/pandas-stubs#296

Closed

nsmith- added a commit to cms-nanoAOD/correctionlib that referenced this issue Sep 13, 2022

Pin formatting CI python version

c5d7e88

To work around python/mypy#13627

merveenoyan mentioned this issue Sep 14, 2022

FEA update_env implementation skops-dev/skops#136

Merged

polm mentioned this issue Sep 14, 2022

Add experimental coref docs explosion/spaCy#11291

Merged

3 tasks

This was referenced Sep 15, 2022

disable mypy run for Python 3.10 explosion/spaCy#11508

Merged

disable mypy run for Python 3.10 explosion/thinc#768

Merged

disable mypy run for Python 3.10 svlandeg/spaCy#12

Closed

disable mypy run for Python 3.10 svlandeg/spaCy#13

Closed

dalcinl added a commit to mpi4py/mpi4py that referenced this issue Sep 15, 2022

test: Temporary workaround for python/mypy#13627

17390ec

This was referenced Sep 15, 2022

Disable mypy for Python 3.10 (develop) explosion/spaCy#11511

Merged

Disable mypy for Python 3.10 (v4) explosion/spaCy#11512

Merged

disable mypy run for Python 3.10 (v9) explosion/thinc#769

Merged

DoctorDalek1963 added a commit to DoctorDalek1963/lintrans that referenced this issue Sep 28, 2022

Bump mypy version to fix python/mypy#13627

1ac2275

hauntsaninja mentioned this issue Sep 28, 2022

More flexible bugfix releases #13752

Closed

This was referenced Sep 29, 2022

Revert Python 3.10.6 pin SeldonIO/alibi-detect#639

Merged

Revert "Temporary fix for mypy issue in Python 3.10 CI (#761)" SeldonIO/alibi#795

Merged

theRealProHacker mentioned this issue Oct 1, 2022

Update run-test.yml theRealProHacker/Positron#38

Merged

whitphx added a commit to whitphx/stlite that referenced this issue Oct 1, 2022

Update mypy due to python/mypy#13627

6b45d8c

whitphx added a commit to whitphx/stlite that referenced this issue Oct 1, 2022

Update mypy due to python/mypy#13627

85a566e

Saransh-cpp mentioned this issue Oct 1, 2022

chore: bump mypy and revert python-version scikit-hep/vector#263

Merged

whitphx added a commit to whitphx/stlite that referenced this issue Oct 2, 2022

Update mypy due to python/mypy#13627

c60da47

jwnimmer-tri mentioned this issue Oct 2, 2022

[workspace] Upgrade mypy_internal to latest commit RobotLocomotion/drake#18022

Merged

astropenguin added a commit to astropenguin/pandas-dataclasses that referenced this issue Oct 5, 2022

#100 Unpin patch version of Python 3.10 (python/mypy#13627)

4053b01

relud mentioned this issue Oct 5, 2022

Update CI to python 3.10 mozilla/bigquery-etl#3248

Merged

Iain-S added a commit to Iain-S/sentry-bot that referenced this issue Oct 7, 2022

Update dependencies

41d554f

The older MyPy version had a bug. See python/mypy#13627

Iain-S mentioned this issue Oct 7, 2022

Update dependencies Iain-S/sentry-bot#28

Merged

Iain-S added a commit to Iain-S/sentry-bot that referenced this issue Oct 7, 2022

Update dependencies

41d7637

The older MyPy version had a bug. See python/mypy#13627

calpaterson added a commit to calpaterson/csvbase that referenced this issue Oct 8, 2022

Deal with a type issue (and solve another)

f1a42e5

python/mypy#13627 now causes spurious errors involving numpy but another type issue is solved.

dalcinl added a commit to mpi4py/mpi4py that referenced this issue Oct 10, 2022

type: Update after resolution of python/mypy#13627

aafd3ec

dalcinl added a commit to mpi4py/mpi4py that referenced this issue Oct 10, 2022

type: Update after resolution of python/mypy#13627

7e02759

hauntsaninja mentioned this issue Oct 13, 2022

python 3.10 in CI, mypy checks files in site-packages #13882

Closed

rhugonnet mentioned this issue Oct 13, 2022

Add Mac and Windows to CI GlacioHack/xdem#304

Merged

otaj mentioned this issue Oct 13, 2022

Bump Python version for mypy check Lightning-AI/pytorch-lightning#15126

Merged

python locked as resolved and limited conversation to collaborators Oct 13, 2022

hauntsaninja unpinned this issue Oct 30, 2022

bengsparks added a commit to multidim-typeinf4py/dynamic-pytypes that referenced this issue Nov 6, 2022

Update dependencies

d39cfa1

Fixes python/mypy#13627

frankh added a commit to PostHog/posthog that referenced this issue Feb 22, 2023

Update mypy to 0.981 for 3.10.7 compatibility

d69d770

Needed this bug to be fixed: python/mypy#13627 This also incidentally fixed the mypy bug in csv_exporter.py

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Positional-only parameters with python 3.10.7 (and numpy) (fixed in 0.981) #13627

Positional-only parameters with python 3.10.7 (and numpy) (fixed in 0.981) #13627

sodul commented Sep 8, 2022

michael-k commented Sep 8, 2022 •

edited

michael-k commented Sep 8, 2022

AlexWaygood commented Sep 8, 2022 •

edited by hauntsaninja

atugushev commented Sep 13, 2022

AlexWaygood commented Sep 13, 2022

hauntsaninja commented Oct 13, 2022

Positional-only parameters with python 3.10.7 (and numpy) (fixed in 0.981) #13627

Positional-only parameters with python 3.10.7 (and numpy) (fixed in 0.981) #13627

Comments

sodul commented Sep 8, 2022

michael-k commented Sep 8, 2022 • edited

michael-k commented Sep 8, 2022

AlexWaygood commented Sep 8, 2022 • edited by hauntsaninja

atugushev commented Sep 13, 2022

AlexWaygood commented Sep 13, 2022

hauntsaninja commented Oct 13, 2022

michael-k commented Sep 8, 2022 •

edited

AlexWaygood commented Sep 8, 2022 •

edited by hauntsaninja