[mypyc] Add LoadAddress op for PyFloat_Type & PyTuple_Type #13078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes mypyc/mypyc#924 - Fixes mypyc/mypyc#926 - Fixes mypyc/mypyc#935 This is a follow-up of commit 7811f08.
ichard26
force-pushed
the
add-float-and-tuple-load-address-ops
branch
from
88ecffb
to
0406c4c
Compare
| 'python_path': tuple, | ||
| 'type': ClassIR, | ||
| 'method': FuncIR, | ||
| 'shadow_method': type, |
There was a problem hiding this comment.
Turning Optional[List] into type isn't great, but that's something to address later.
JelleZijlstra
approved these changes
Jul 12, 2022
This was referenced Jul 14, 2022
hauntsaninja
pushed a commit
to hauntsaninja/mypy
that referenced
this pull request
Jul 16, 2022
) - Fixes mypyc/mypyc#924 - Fixes mypyc/mypyc#926 - Fixes mypyc/mypyc#935 This is a follow-up of commit 7811f08.
ilevkivskyi
pushed a commit
that referenced
this pull request
Jul 16, 2022
…13150) - Fixes mypyc/mypyc#924 - Fixes mypyc/mypyc#926 - Fixes mypyc/mypyc#935 This is a follow-up of commit 7811f08. Co-authored-by: Richard Si <63936253+ichard26@users.noreply.github.com>
Gobot1234
pushed a commit
to Gobot1234/mypy
that referenced
this pull request
Aug 12, 2022
) - Fixes mypyc/mypyc#924 - Fixes mypyc/mypyc#926 - Fixes mypyc/mypyc#935 This is a follow-up of commit 7811f08.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up of commit 7811f08.
Test Plan
I took all of the downgraded / failing examples in the linked issues and rewrote them as run tests.