Fix crash in match statement if class name is undefined #12417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhance
approved these changes
Mar 21, 2022
test-data/unit/check-python310.test
Outdated
|
|
||
| match m: | ||
| case xyz(y=z): # E: Name "xyz" is not defined | ||
| reveal_type(y) # E: Cannot determine type of "y" \ |
There was a problem hiding this comment.
Suggested change
| reveal_type(y) # E: Cannot determine type of "y" \ | |
| reveal_type(z) # E: Cannot determine type of "z" \ |
I think it picks it up y from the previous match
| match m: | ||
| case xyz(y): # E: Name "xyz" is not defined | ||
| reveal_type(m) # N: Revealed type is "Any" | ||
| reveal_type(y) # E: Cannot determine type of "y" \ |
There was a problem hiding this comment.
"Cannot determine type" is a bit unfortunate; I'd rather it's just Any. Probably fine this way though.
There was a problem hiding this comment.
Yeah, Any would be better, but I think that this would require a much bigger change.
JelleZijlstra
approved these changes
Mar 21, 2022
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12416.