Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'"dict" is not subscriptable' error when using a type alias for dict in a .pyi stub file, with Python <= 3.8 #11859

Closed
AlexWaygood opened this issue Dec 28, 2021 · 2 comments · Fixed by #11918
Labels
bug mypy got something wrong

Comments

@AlexWaygood
Copy link
Member

Bug Report

This error only occurs when mypy is run using Python <= 3.8. Here is a minimal reproducible example:

_DictReadMapping = dict

class Foo(_DictReadMapping[str, int]): ...  # error: "dict" is not subscriptable
Bar = _DictReadMapping[int, str]  # error: "dict" is not subscriptable

The following, however, do not cause an error in Python <= 3.8 in a .pyi stub file:

_DictReadMapping = dict

Baz: _DictReadMapping[str, int]  # type alias used as an annotation: okay
class Spam(dict[str, int]): ...  # `dict` used as superclass without a type alias: okay

Expected Behavior

In Python <= 3.8, dict is not subscriptable at runtime. However, it should be subscriptable in a .pyi stub file, which does not need to ever be "run". Moreover, it is subscriptable in a .pyi file if a type alias is not being used. The behaviour should be the same, whether or not you are using a type alias.

Your Environment

This bug has been reproduced on MacOS, Ubuntu and Windows on Python 3.6, 3.7 and 3.8. The mypy version being used is 0.930.

Use case

I came across this bug in an early draft of python/typeshed#6717. As you can see, using this kind of syntax fails the typeshed CI for mypy, but not for any other type checker. (In this case, there was an easy workaround.)

@AlexWaygood AlexWaygood added the bug mypy got something wrong label Dec 28, 2021
@AlexWaygood
Copy link
Member Author

(Cc. @JukkaL, @sobolevn, since this is somewhat related to python/typeshed#4820)

@sobolevn
Copy link
Member

Related to #11863

I can refactor TypeAlias logic after my initial PR is merged 👍

hauntsaninja pushed a commit to hauntsaninja/mypy that referenced this issue Jan 6, 2022
JukkaL pushed a commit that referenced this issue Jan 6, 2022
Fixes #11859

Co-authored-by: hauntsaninja <>
JukkaL pushed a commit that referenced this issue Jan 6, 2022
Fixes #11859

Co-authored-by: hauntsaninja <>
tushar-deepsource pushed a commit to DeepSourceCorp/mypy that referenced this issue Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug mypy got something wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants