Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.910 planning #10622

Closed
JukkaL opened this issue Jun 10, 2021 · 17 comments
Closed

Release 0.910 planning #10622

JukkaL opened this issue Jun 10, 2021 · 17 comments

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Jun 10, 2021

I'm planning to release mypy 0.910 next week. It's only going to me a small feature release -- cherry-picks on top of 0.902. The main thing I want in is mypy --install-types --non-interactive (#10616). I'll probably also cherry-pick some typeshed fixes (#10621). If anybody wants something else in the release, please leave a comment here.

I probably won't include any new features unless they address some issue introduced in 0.900.

@Akuli
Copy link
Contributor

Akuli commented Jun 10, 2021

Maybe also cherry-pick python/typeshed#5579

@hauntsaninja
Copy link
Collaborator

Thoughts on #10560 ? Fixes crashes that have been reported multiple times.

@JukkaL
Copy link
Collaborator Author

JukkaL commented Jun 11, 2021

Any fixes to crashes are potentially good, as long as the fix doesn't seem risky (since we aren't going to follow our full, safe release process).

@srittau
Copy link
Contributor

srittau commented Jun 11, 2021

The stubgen PRs (#10623, #10624, #10625, and #10626 if it gets approved) would be low risk for mypy itself, but could prevent unsuitable typeshed submissions.

@JukkaL
Copy link
Collaborator Author

JukkaL commented Jun 17, 2021

The stubgen updates sound all good.

Some other PRs that seem safe:

Since there have been some recent fixes related to type packages, I might postpone the release for a few days until early next week to give more time for further issues to come up.

@JukkaL
Copy link
Collaborator Author

JukkaL commented Jun 17, 2021

I'd also like to fix #10653 (crash), which is a regression from 0.812, assuming we can find a self-contained repro.

The crash #10647 also sounds possibly bad, though I haven't looked into it in any detail yet.

Fixing #10645 at least partially would also be nice.

Finally, this improvement to --install-types --non-interactive could be nice to have: #10600 (comment)

@JukkaL
Copy link
Collaborator Author

JukkaL commented Jun 17, 2021

Also it would be good to improve the error message when --install-types can't find a mypy cache (see discussion in #10600).

@TH3CHARLie
Copy link
Collaborator

I can help bisect #10653 and see if I can fix it

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Jun 18, 2021

mypy_primer can make bisection easier, try: mypy_primer -p test.py --bisect --old v0.812 (although there might be some issues crossing back and forth between getting rid of submodules / if there are other changes you might want to use --bisect-output AssertionError / pass --debug to see what it's doing)

@TH3CHARLie
Copy link
Collaborator

cool, I wasn't aware mypy_primer has these functionalities

@srittau
Copy link
Contributor

srittau commented Jun 21, 2021

Another package name fix: #10681.

@JukkaL
Copy link
Collaborator Author

JukkaL commented Jun 21, 2021

#10653 is the biggest remaining potential release blocker for which we don't have a PR yet. I'll also want to make some documentation and/error message updates, but these are straightforward.

I may skip the typeshed cherry-picks, since I've been busy with other fixes, and we don't have an existing workflow for performing cherry-picks.

@TH3CHARLie
Copy link
Collaborator

TH3CHARLie commented Jun 22, 2021

@JukkaL do you have a hard expected deadline for this release? if so we may need some quick (and therefore maybe dirty) patch to address #10653

@JukkaL
Copy link
Collaborator Author

JukkaL commented Jun 22, 2021

I don't have a hard deadline, so it's basically "as soon as feasible". I'll have a look at #10653 today.

@JukkaL
Copy link
Collaborator Author

JukkaL commented Jun 22, 2021

The release-0.910 branch now contains all the things I want. I'll do some more testing and if everything goes well, I'm planning to make the release later today (Tue).

@JukkaL
Copy link
Collaborator Author

JukkaL commented Jun 23, 2021

The 0.910 release is out: https://mypy-lang.blogspot.com/2021/06/mypy-0910-released.html

@JukkaL JukkaL closed this as completed Jun 23, 2021
@christianbundy
Copy link
Contributor

There have been ~180 commits since this release, is there anything I can do to help get another release cut?

(Apologies for the necro-bump, I was going to make a new issue but the issue template says not to make issues for questions.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants