Don't suggest installing types-pycrypto #10603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't exist, since it was removed from typeshed in October (python/typeshed#4606). Similarly, pynamodb was removed in January. I haven't tracked down what happened to pyre-extensions in typeshed, but https://pypi.org/project/types-pyre-extensions/ doesn't exist and in any case mypy users presumably don't need it.
|
Looks like I'll need to update some tests as well. |
TH3CHARLie
approved these changes
Jun 9, 2021
|
Thanks for fixing this and uploading the dummy packages! I forgot to double check that the suggestions are still up to date. @JelleZijlstra uploaded PyPI dummy packages for these so that there is no security risk. Still, I think it makes to release 0.902 with this fix, but I think that it can wait a few days at least so that we can include other fixes as well if we want. |
JukkaL
pushed a commit
that referenced
this pull request
Jun 10, 2021
It doesn't exist, since it was removed from typeshed in October (python/typeshed#4606). Similarly, pynamodb was removed in January. I haven't tracked down what happened to pyre-extensions in typeshed, but https://pypi.org/project/types-pyre-extensions/ doesn't exist and in any case mypy users presumably don't need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't exist, since it was removed from typeshed in October (python/typeshed#4606). Similarly, pynamodb was removed in January.
I haven't tracked down what happened to pyre-extensions in typeshed, but https://pypi.org/project/types-pyre-extensions/ doesn't exist and in any case mypy users presumably don't need it.