Make ignore_missing_imports work for libs which had bundled stubs #10582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has to be specified as a per-module option, if the library used to have bundled stubs. This way mypy won't silently start ignoring these missing stubs. This makes `ignore_missing_imports` special by making it work a bit differently, depending on whether it's set globally or per module. The new behavior is less surprising. This makes it possible to ignore arbitrary missing third-party stub packages, even those which used to have bundled stubs. Fixes #10283.
ilevkivskyi
approved these changes
Jun 4, 2021
JukkaL
added a commit
that referenced
this pull request
Jun 7, 2021
…0582) It has to be specified as a per-module option, if the library used to have bundled stubs. This way mypy won't silently start ignoring these missing stubs. This makes ignore_missing_imports special by making it work a bit differently, depending on whether it's set globally or per module. The new behavior is less surprising. This makes it possible to ignore arbitrary missing third-party stub packages, even those which used to have bundled stubs. Fixes #10283. Originally implemented by @TheCleric in #10283. This is somewhat simpler alternative implementation which is easier to reason about and may perform better in some cases of very large configs.
|
I think that this broke |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has to be specified as a per-module option, if the library used
to have bundled stubs. This way mypy won't silently start ignoring
these missing stubs.
This makes
ignore_missing_importsspecial by making it work a bitdifferently, depending on whether it's set globally or per module.
The new behavior is less surprising. This makes it possible to ignore
arbitrary missing third-party stub packages, even those which used to
have bundled stubs.
Fixes #10283.
Originally implemented by @TheCleric in #10283. This is somewhat
simpler alternative implementation which is easier to reason about and
may perform better in some cases of very large configs.