Resolves #10542 Add fullname of node that is still a PlaceholderNode when assertion fails #10565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#10542 had a vague error come up due to a PlaceholderNode that did not get replaced. This PR simply adds the full name of the node so that these can be better traced back.
The error was:
Will now be slightly more helpful:
There's the possibility that something bigger needs to happen here (why is it still a PlaceholderNode?), but this was enough to help me to figure out how to move #10542 forward.
Test Plan
Manually tested with the code provided by @ZeeD
from spacy import load
ran through mypy with--strict