Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention API ref & migration guide in importlib_metadata See Also #401

Merged
merged 1 commit into from Oct 1, 2022

Conversation

CAM-Gerlach
Copy link
Member

Per #400 and as As discussed on the Python Discourse, this clarifies the Using importlib_metadata documentation (and thus its CPython equivalent) that the API documentation (and migration guide) for the latest version of importlib.metadata` can be found on the importlib_metadata`` docs site.

Fix #400

Comment on lines +31 to +36
This includes an `API reference
<https://importlib-metadata.readthedocs.io/en/latest/api.html>`__
for this module's classes and functions,
as well as a `migration guide
<https://importlib-metadata.readthedocs.io/en/latest/migration.html>`__
for existing users of ``pkg_resources``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little concerned about adding multiple references and keeping those in sync. Why not just "..., which supplies a backport of importlib.metadata and includes an API reference and migration guide for users of pkg_resources." That would inform the users of the presence of those aspects without keeping them linked.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. We could use :ref: via Intersphinx which would keep them in sync automatically, though that would require adding intersphinx to the CPython docs build config which I'm not sure the downstreams would like (since it requires either network access or a local cache when building docs). But if you think so, we can just go with it for now—you're the maintainer, of course.

Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one question.

@jaraco
Copy link
Member

jaraco commented Oct 1, 2022

On further consideration, let's try the links. If they become onerous to maintain, we may replace them later with a less specific reference.

@jaraco jaraco merged commit 9a6641b into python:main Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add note that API docs (and migration guide) can be found on importlib_metadata docs
2 participants