Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): Path-likes use truediv #335

Merged
merged 6 commits into from
Aug 12, 2021
Merged

fix(typing): Path-likes use truediv #335

merged 6 commits into from
Aug 12, 2021

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Aug 5, 2021

Fixes #334.

@henryiii
Copy link
Contributor Author

henryiii commented Aug 5, 2021

If you'd like a test, something like this could be added:

if typing.TYPE_CHECKING:
    from pathlib import Path
    _: SimplePath = typing.cast(Path, None)

@FFY00
Copy link
Member

FFY00 commented Aug 5, 2021

@jaraco if you could merge this and #336 and then make a release, it would be great 😊. Thanks!

@jaraco
Copy link
Member

jaraco commented Aug 12, 2021

In d491aea and 9e42358, I attempted to add the test, but it doesn't fail, so I'll plan to merge without a regression test.

@jaraco jaraco merged commit 8806606 into python:main Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimplePath protocol should use __truediv__, not __div__
3 participants