Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DistributionNotFound for typing-extensions with Python 3.10 #271

Closed
williamjmorenor opened this issue Jan 1, 2021 · 5 comments
Closed
Labels
invalid This doesn't seem right

Comments

@williamjmorenor
Copy link

Hello with python 3.10 alpha looks like there is a issue with the version check of importlib_metadata

'typing-extensions>=3.6.4; python_version < "3.8"' distribution was not found and is required by importlib-metadata

Look like comparing "3.10" > "3.8" is returning False in some place.

References:

@FFY00
Copy link
Member

FFY00 commented Jan 1, 2021

As I said in the pypa/build issue, this looks like an issue in twine. importlib_metadata should have nothing to do with it.

@sigmavirus24
Copy link

@FFY00 You're saying twine shouldn't use importlib_metadata?

@layday
Copy link
Contributor

layday commented Jan 2, 2021

No, he's saying that the issue does not originate from (or manifest in) importlib_metadata. twine uses pkg_resources to load its commands from setuptools entry points and pkg_resources for some reason attempts to validate that dependencies are met and chokes on python_version < "3.8" when the python_version is 3.10. The issue in twine could be obviated by using importlib-metadata, which it already depends on, to load its entry points.

@bhrutledge
Copy link
Contributor

I believe this can be closed, as the underlying exception reported by Twine can be resolved by upgrading to setuptools>=49.0.0, as detailed at pypa/twine#724 (comment).

williamjmorenor added a commit to cacao-accounting/cacao-accounting that referenced this issue Jan 3, 2021
@jaraco
Copy link
Member

jaraco commented Jan 10, 2021

Thanks all for working through the challenges here.

@jaraco jaraco closed this as completed Jan 10, 2021
@jaraco jaraco added the invalid This doesn't seem right label Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

6 participants